RANGER-5343: Add unit test cases for hbase-agent module #695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhavalshah9131
requested review from
dineshkumar-yadav,
kishorgollapalliwar,
kumaab and
pradeepagrawal8184
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive unit test coverage for the HBase Security Plugin module, increasing test coverage significantly across multiple packages (from 7-14% to 79-100%). The tests were AI-generated using Cursor AI and manually reviewed.
Key Changes:
- Added 9 new test classes covering client, service, and authorization components
- Introduced mockito-inline and mockito-junit-jupiter dependencies for advanced mocking capabilities
- Migrated existing test from JUnit 4 to JUnit 5 (Jupiter)
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| TestHBaseResourceMgr.java | New test class covering HBase resource lookup and connection testing functionality |
| TestHBaseConnectionMgr.java | New test class validating connection caching and reconnection logic |
| TestHBaseClient.java | New comprehensive test class for HBase client operations including status checks and resource listing |
| TestRangerServiceHBase.java | Updated test class migrated to JUnit 5 with expanded coverage for service validation and policy generation |
| TestRangerHBaseResource.java | New test class for HBase resource namespace handling and value management |
| TestRangerHBasePlugin.java | New test class covering plugin shutdown behavior and configuration |
| TestHbaseUserUtilsImpl.java | New test class for user utility functions and superuser checks |
| TestHbaseFactory.java | New test class for factory singleton and provider initialization |
| TestHbaseConstants.java | New test class for constants class coverage |
| TestHbaseAuditHandlerImpl.java | New test class for audit event handling and superuser override logic |
| HbaseAuthUtilsImplTest.java | Updated test class with expanded coverage for authentication utilities |
| AuthorizationSessionTest.java | Updated test class with comprehensive coverage of authorization session lifecycle |
| pom.xml | Added mockito-inline and mockito-junit-jupiter test dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
AI Disclosure
Added AI-generated Test methods/Test classes using Cursor AI for HBase Security Plugin module and manually reviewed.
Added unit test cases for hbase-agent module
How was this patch tested?
Build completed successfully along with all test cases using the command: mvn clean compile package install.
As per Jacoco
Apache -> HBase Security Plugin
Packages Covered
Improved Jacoco coverage across multiple packages:
org.apache.ranger.authorization.hbase → 14% → 79%
org.apache.ranger.services.hbase → 7% → 100%
org.apache.ranger.services.hbase.client → 0% → 89%